[webkit-reviews] review granted: [Bug 24810] Trying to get the Windows BuildBot into the Green : [Attachment 28940] Patch of Windows Skip List

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 25 14:15:21 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at gmail.com>'s request for review:
Bug 24810: Trying to get the Windows BuildBot into the Green
https://bugs.webkit.org/show_bug.cgi?id=24810

Attachment 28940: Patch of Windows Skip List
https://bugs.webkit.org/attachment.cgi?id=28940&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
r=me as-is

I think some improvements could be made, though:

* There should be a space after the leading "#" on the comment lines, to match
other lines in this file
* It would be good to put a comment at the end of this new section, too, so
that people don't just add to the bottom of the file and mistakenly put the new
failures in the r41975 section.


More information about the webkit-reviews mailing list