[webkit-reviews] review granted: [Bug 23932] Current API does not allow us to open target="_blank" links in new tabs instead of windows : [Attachment 28850] New version of the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 25 03:52:12 PDT 2009


Holger Freyther <zecke at selfish.org> has granted Alejandro Garcia Castro
<alex at igalia.com>'s request for review:
Bug 23932: Current API does not allow us to open target="_blank" links in new
tabs instead of windows
https://bugs.webkit.org/show_bug.cgi?id=23932

Attachment 28850: New version of the patch
https://bugs.webkit.org/attachment.cgi?id=28850&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Please use the prepare-ChangeLog script in the future and who ever lands this
patch please fix the coding style.



> +2009-03-23  Alejandro Garcia Castro	<alex at igalia.com>
> +
> +	   Reviewed by .

tabs?


> +	   * WebCoreSupport/FrameLoaderClientGtk.cpp:

tabs? and maybe even in th enext lines...



>      // FIXME: I think Qt version marshals this to another thread so when we
>      // have multi-threaded download, we might need to do the same
> -    (core(m_frame)->loader()->*policyFunction)(PolicyUse);
> +    if (!isHandled)
> +	   webkit_web_policy_decision_use(m_policyDecision);

please don't include this hunk in this when landing, IIRC there was another
patch making these consistent!



> +    WebKitWebNavigationAction* navigationAction = getNavigationAction
(action);

Coding Style, no ' ' between Action and (action) please. The other call to
getNavigationAction was wrong too.


More information about the webkit-reviews mailing list