[webkit-reviews] review granted: [Bug 24693] Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0 : [Attachment 28744] Patch to disable all the SVG features for WebKit/Qt if ENABLE_SVG=0

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 24693: Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
https://bugs.webkit.org/show_bug.cgi?id=24693

Attachment 28744: Patch to disable all the SVG features for WebKit/Qt if
ENABLE_SVG=0
https://bugs.webkit.org/attachment.cgi?id=28744&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Looks sensible and will work with the below macros. Another way would be to put
the ENABLE_SVG_* macros into a block...

e.g. contains(DEFINES, ENABLE_SVG=1) {
   !contains(FOO): DEFINES += ENABLE_FOO=1
}

but I would have to check the qmake manual... it would be nice if you could do
a follow up.