[webkit-reviews] review requested: [Bug 15312] WebKit applies an incorrect min width for <input type="text"> fields : [Attachment 28920] Make textarea metrics more closely match IEs.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 18:42:31 PDT 2009


Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 15312: WebKit applies an incorrect min width for <input type="text"> fields
https://bugs.webkit.org/show_bug.cgi?id=15312

Attachment 28920: Make textarea metrics more closely match IEs.
https://bugs.webkit.org/attachment.cgi?id=28920&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
 LayoutTests/ChangeLog				    |	23 +++
 LayoutTests/fast/forms/resources/TEMPLATE.html     |	13 ++
 .../fast/forms/resources/textarea-metrics.js	    |  171 +++++++++++++++++++
 .../fast/forms/textarea-metrics-expected.txt	    |  173 ++++++++++++++++++++
 LayoutTests/fast/forms/textarea-metrics.html	    |	13 ++
 .../custom/resources/svg-fonts-in-text-controls.js |	20 +++
 .../custom/svg-fonts-in-text-controls-expected.txt |	 6 +
 .../svg/custom/svg-fonts-in-text-controls.html     |	13 ++
 WebCore/ChangeLog				    |	60 +++++++
 WebCore/css/html4.css				    |	 2 +
 WebCore/css/themeWin.css			    |	 4 -
 WebCore/platform/graphics/SimpleFontData.cpp	    |	70 ++++++++-
 WebCore/platform/graphics/SimpleFontData.h	    |	 7 +
 .../chromium/SimpleFontDataChromiumWin.cpp	    |	 5 +
 .../graphics/chromium/SimpleFontDataLinux.cpp	    |	 5 +
 WebCore/platform/graphics/mac/SimpleFontDataMac.mm |	21 +++
 .../platform/graphics/win/SimpleFontDataCGWin.cpp  |	 7 +
 .../graphics/win/SimpleFontDataCairoWin.cpp	    |	 7 +
 .../platform/graphics/win/SimpleFontDataWin.cpp    |	 2 +
 WebCore/rendering/RenderTextControl.cpp	    |	 6 +-
 WebCore/rendering/RenderTextControlMultiLine.cpp   |	 4 -
 WebCore/rendering/RenderTextControlSingleLine.cpp  |	 4 +
 22 files changed, 619 insertions(+), 17 deletions(-)


More information about the webkit-reviews mailing list