[webkit-reviews] review requested: [Bug 24723] Use the proper definition of RETURN_PAIR on !MSVC : [Attachment 28911] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 15:07:46 PDT 2009


Mike Hommey <mh+webkit at glandium.org> has asked	for review:
Bug 24723: Use the proper definition of RETURN_PAIR on !MSVC
https://bugs.webkit.org/show_bug.cgi?id=24723

Attachment 28911: patch v2
https://bugs.webkit.org/attachment.cgi?id=28911&action=review

------- Additional Comments from Mike Hommey <mh+webkit at glandium.org>
I think this patch should be safe. I see no reason why any 32-bits platforms
couldn't use the second definition, while 64-bits platforms (only x86-64 at the
moment) use the first one.

It makes things simpler on the long term, IMHO.


More information about the webkit-reviews mailing list