[webkit-reviews] review granted: [Bug 24684] Clean up WebCore based on Coverty Prevent static analysis results : [Attachment 28903] Fix case where lBreak.obj->isBR() when lBreak.obj was NULL

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 24684: Clean up WebCore based on Coverty Prevent static analysis results
https://bugs.webkit.org/show_bug.cgi?id=24684

Attachment 28903: Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
https://bugs.webkit.org/attachment.cgi?id=28903&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
> +	https://bugs.webkit.org/show_bug.cgi?id=24684
> +
> +	I don't have a test case where we were taking the wrong path here
> +	However, adding an ASSERT(lBreak.obj) before this usage caused
> +	multiple bidi tests to fail, so lBreak.obj can be null here.

Tabs in ChangeLog.

> -    if (lBreak == resolver.position() && !lBreak.obj->isBR()) {
> +    if (lBreak == resolver.position() && (!lBreak.obj ||
!lBreak.obj->isBR())) {

Seems harmless to add this, even though it may be impossible in practice.

r=me