[webkit-reviews] review requested: [Bug 16482] Hook up ICU's encoding detector and add a boolean param to Settings and WebPreferences : [Attachment 28897] updated patch (the same as the previous one except for a 1-line chnage)

[bugzilla-daemon at webkit.org]

Jungshik Shin <jshin at chromium.org> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 16482: Hook up ICU's encoding detector and add a boolean param to Settings
and WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=16482

Attachment 28897: updated patch (the same as the previous one except for a
1-line chnage)
https://bugs.webkit.org/attachment.cgi?id=28897&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
This is the same as the previous one except that in flush(), I put
'shouldAutoDetect()' before other checks to short-circuit  in the default case
where auto-detection is OFF.  This was tested in Chromium trunk on Windows (the
previous patches have been in Chromium for over a year).