[webkit-reviews] review cancelled: [Bug 24696] Add security context to Chromium's ResourceRequest : [Attachment 28749] patchzor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 11:44:28 PDT 2009

Adam Barth <abarth at webkit.org> has cancelled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 24696: Add security context to Chromium's ResourceRequest

Attachment 28749: patchzor

------- Additional Comments from Adam Barth <abarth at webkit.org>
> Adam, is this really only helpful for Chromium?  Could other ports not
> from having security context information here?

You're right, we should move this to ResourceRequestBase.  You need this
information to correctly compute the mixed content state for HTTPS.  I think we
haven't noticed this before because Safari doesn't have a mixed content
indicator.  Clearing review flag while I work up a new patch.

More information about the webkit-reviews mailing list