[webkit-reviews] review granted: [Bug 24779] Conditionalize CFNetwork-Specific Code in WebView : [Attachment 28893] Exclude CFNetwork-specific calls in non-Apple builds.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted 's request for review:
Bug 24779: Conditionalize CFNetwork-Specific Code in WebView
https://bugs.webkit.org/show_bug.cgi?id=24779

Attachment 28893: Exclude CFNetwork-specific calls in non-Apple builds.
https://bugs.webkit.org/attachment.cgi?id=28893&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebKit/win/WebView.cpp	(working copy)
> @@ -50,7 +50,9 @@
>  #include "WebNotificationCenter.h"
>  #include "WebPreferences.h"
>  #pragma warning( push, 0 )
> +#if PLATFORM(CG)
>  #include <CoreGraphics/CGContext.h>
> +#endif

It would be better to move the conditionally-included headers down below the
unconditionally-included headers. Each #if/#endif pair can form its own
paragraph.

> +#include <CoreFoundation/CoreFoundation.h>

Should this be inside #if PLATFORM(CF)/#endif?

r=me