[webkit-reviews] review denied: [Bug 24776] Disabling HTML5 Database breaks the build : [Attachment 28891] Proposed fix for #ifdefs in Document and InspectorController
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 24 10:48:24 PDT 2009
Sam Weinig <sam at webkit.org> has denied Ben Murdoch <benm at google.com>'s request
for review:
Bug 24776: Disabling HTML5 Database breaks the build
https://bugs.webkit.org/show_bug.cgi?id=24776
Attachment 28891: Proposed fix for #ifdefs in Document and InspectorController
https://bugs.webkit.org/attachment.cgi?id=28891&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
Why not just put an #ifdef around Database.cpp so it doesn't compile?
> + void Document::setHasOpenDatabases();
> + bool Document::hasOpenDatabases();
Also, this will break some builds, r-.
More information about the webkit-reviews
mailing list