[webkit-reviews] review granted: [Bug 23310] Setting an absolute path (/abs) on an <iframe> with no src doesn't resolve the URL properly : [Attachment 28881] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 09:02:38 PDT 2009


Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 23310: Setting an absolute path (/abs) on an <iframe> with no src doesn't
resolve the URL properly
https://bugs.webkit.org/show_bug.cgi?id=23310

Attachment 28881: Patch v2
https://bugs.webkit.org/attachment.cgi?id=28881&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    const KURL baseURL = ((m_baseURL.isEmpty() || m_baseURL == blankURL())
&& parentDocument()) ? parentDocument()->baseURL() : m_baseURL;

This should be const KURL&, not const KURL.

r=me


More information about the webkit-reviews mailing list