[webkit-reviews] review requested: [Bug 24692] Allow ChromeClientChromium to access an HTML select element's menu items : [Attachment 28880] Updated patch for handling select elements in the chromium port

[bugzilla-daemon at webkit.org]

Paul Godavari <paul at chromium.org> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 24692: Allow ChromeClientChromium to access an HTML select element's menu
items
https://bugs.webkit.org/show_bug.cgi?id=24692

Attachment 28880: Updated patch for handling select elements in the chromium
port
https://bugs.webkit.org/attachment.cgi?id=28880&action=review

------- Additional Comments from Paul Godavari <paul at chromium.org>
1. Removed the per platform files and used PLATFORM(DARWIN) for determining
whether to call show() or showSelect().

2. I didn't create a struct for the PopupListBox data, since we're only
interested in a part of it (item height, selected index and item list), and
there remains several other data members. It just seems a little strange to
include some members and not the others in the struct. If you feel strongly
about it, I'll make that change.