[webkit-reviews] review granted: [Bug 24762] Text-indent is not supported on <option> elements : [Attachment 28872] Second try.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 23 16:32:39 PDT 2009
Adele Peterson <adele at apple.com> has granted 's request for review:
Bug 24762: Text-indent is not supported on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=24762
Attachment 28872: Second try.
https://bugs.webkit.org/attachment.cgi?id=28872&action=review
------- Additional Comments from Adele Peterson <adele at apple.com>
I think you have extra spacing on the last line here.
> + maxOptionWidth = max(maxOptionWidth, optionWidth);
> + } else if (!text.isEmpty())
> + maxOptionWidth = max(maxOptionWidth,
style()->font().floatWidth(text));
> }
Looks good! r=me.
More information about the webkit-reviews
mailing list