[webkit-reviews] review requested: [Bug 24704] DumpRenderTree (OSX version) should be able to run independent instances at the same time. : [Attachment 28863] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 23 13:27:27 PDT 2009


David Levin <levin at chromium.org> has asked  for review:
Bug 24704: DumpRenderTree (OSX version) should be able to run independent
instances at the same time.
https://bugs.webkit.org/show_bug.cgi?id=24704

Attachment 28863: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=28863&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Address previous issues.

This patch still exports WebKitLocalCacheDefaultsKey as opposed to making it a
constant.  I was following the pattern of what was done for
WebDatabaseDirectoryDefaultsKey in
WebKit/mac/Storage/WebDatabaseManagerPrivate.h.

If something different should be done in this case, let me know and I can
change it.


More information about the webkit-reviews mailing list