[webkit-reviews] review requested: [Bug 24739] Combine StringImpl struct and data allocations : [Attachment 28862] patch with Darin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 23 12:38:49 PDT 2009


Mike Belshe <mike at belshe.com> has asked Darin Adler <darin at apple.com> for
review:
Bug 24739: Combine StringImpl struct and data allocations
https://bugs.webkit.org/show_bug.cgi?id=24739

Attachment 28862: patch with Darin's comments
https://bugs.webkit.org/attachment.cgi?id=28862&action=review

------- Additional Comments from Mike Belshe <mike at belshe.com>
Thanks for the comments; sorry about the stupid nits.

I moved both operator new() calls to be private; I hadn't done this before to
be conservative.  But after re-testing, all callers are using the create()
methods (which is good!), so I was able to make this private.


More information about the webkit-reviews mailing list