[webkit-reviews] review denied: [Bug 23252] need a flag to remove the selection rectangle in text controls : [Attachment 26632] add a flag to remove the selection rectangle in text controls
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 23 11:51:58 PDT 2009
Adele Peterson <adele at apple.com> has denied scroggo at google.com's request for
review:
Bug 23252: need a flag to remove the selection rectangle in text controls
https://bugs.webkit.org/show_bug.cgi?id=23252
Attachment 26632: add a flag to remove the selection rectangle in text controls
https://bugs.webkit.org/attachment.cgi?id=26632&action=review
------- Additional Comments from Adele Peterson <adele at apple.com>
I agree with Mark. Its unnecessary to have all these #defines. One way to do
this would be to cause the selection color to be clear in methods like
platformActiveSelectionBackgroundColor. Or you could have RenderTheme/some
other platform class provide a way to tell if selection is supported on a
particular platform, and you could ask that method before drawing selection.
More information about the webkit-reviews
mailing list