[webkit-reviews] review denied: [Bug 24685] Use Skia integer primitives for drawing Chromium Linux scrollbars : [Attachment 28737] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Adam Langley
<agl at chromium.org>'s request for review:
Bug 24685: Use Skia integer primitives for drawing Chromium Linux scrollbars
https://bugs.webkit.org/show_bug.cgi?id=24685

Attachment 28737: patch
https://bugs.webkit.org/attachment.cgi?id=28737&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
> +static void drawVertLine(SkCanvas* canvas, int x, int y1, int y2, const
SkPaint& paint) {
> +  SkIRect skrect;
> +  skrect.set(x, y1, x + 1, y2 + 1);
> +  canvas->drawIRect(skrect, paint);
> +}

nit: please use webkit style (4 space indent, bracket on newline).  there are a
lot of
these style violations in this patch as well as in the previous file.  please
fix :)