[webkit-reviews] review requested: [Bug 24760] Clean up Position.h : [Attachment 28855] Remove Position::clear() and make VisibleSelection.h not include VisiblePosition.h

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 24760: Clean up Position.h
https://bugs.webkit.org/show_bug.cgi?id=24760

Attachment 28855: Remove Position::clear() and make VisibleSelection.h not
include VisiblePosition.h
https://bugs.webkit.org/attachment.cgi?id=28855&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog				    |	57 ++++++++++++++++++++
 WebCore/dom/Position.cpp			    |	 6 +-
 WebCore/dom/Position.h 			    |	12 ++--
 WebCore/dom/RangeBoundaryPoint.h		    |	 2 +-
 WebCore/editing/ApplyStyleCommand.cpp		    |	 1 +
 WebCore/editing/CompositeEditCommand.cpp	    |	 1 +
 WebCore/editing/DeleteButtonController.cpp	    |	 1 +
 WebCore/editing/DeleteSelectionCommand.cpp	    |	15 +++---
 WebCore/editing/FormatBlockCommand.cpp 	    |	 1 +
 WebCore/editing/IndentOutdentCommand.cpp	    |	 1 +
 WebCore/editing/InsertListCommand.cpp		    |	 1 +
 .../editing/InsertParagraphSeparatorCommand.cpp    |	 1 +
 WebCore/editing/InsertTextCommand.cpp		    |	 1 +
 WebCore/editing/ReplaceSelectionCommand.cpp	    |	 1 +
 WebCore/editing/SelectionController.cpp	    |	 1 +
 WebCore/editing/TextIterator.cpp		    |	 1 -
 WebCore/editing/VisiblePosition.h		    |	 9 ++--
 WebCore/editing/VisibleSelection.cpp		    |	10 ++++
 WebCore/editing/VisibleSelection.h		    |	 8 ++--
 WebCore/editing/markup.cpp			    |	 1 +
 WebCore/page/AccessibilityObject.h		    |	 4 ++
 WebCore/page/AccessibilityRenderObject.h	    |	 1 +
 WebCore/page/DOMSelection.cpp			    |	 1 +
 WebCore/page/DragController.cpp		    |	 1 +
 WebCore/page/Frame.cpp 			    |	 9 ++--
 WebCore/page/mac/FrameMac.mm			    |	 1 +
 WebCore/rendering/RenderBlock.cpp		    |	 1 +
 WebCore/rendering/RenderBox.cpp		    |	 1 +
 WebCore/rendering/RenderTextControl.cpp	    |	 1 +
 WebCore/rendering/TextControlInnerElements.cpp     |	 1 +
 WebCore/svg/SVGTextContentElement.cpp		    |	 1 +
 31 files changed, 122 insertions(+), 31 deletions(-)