[webkit-reviews] review denied: [Bug 24757] Chromium port doesn't support opacity on complex text : [Attachment 28852] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 23 08:52:00 PDT 2009
Eric Seidel <eric at webkit.org> has denied Brett Wilson (Google)
<brettw at chromium.org>'s request for review:
Bug 24757: Chromium port doesn't support opacity on complex text
https://bugs.webkit.org/show_bug.cgi?id=24757
Attachment 28852: Patch
https://bugs.webkit.org/attachment.cgi?id=28852&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
ChangeLog needed.
I'm surprised there isn't a test to cover this already?
WK style is "init()":
void Init();
I'm unclear as to why Init needs to be separate from construction? (And I'm
also not sure why a generalized "init" function is preferred over the old
initForGDI())
Otherwise this looks fine. I think mostly it just needs a ChangeLog to
document what you're doing (so the reviewer can more easily understand what
you're doing). ;)
More information about the webkit-reviews
mailing list