[webkit-reviews] review granted: [Bug 24719] QTMovieWinTimer logic inversion : [Attachment 28798] updated patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 24719: QTMovieWinTimer logic inversion
https://bugs.webkit.org/show_bug.cgi?id=24719

Attachment 28798: updated patch
https://bugs.webkit.org/attachment.cgi?id=28798&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    } else if (message == WM_TIMER && wParam == timerID) {
> +	   KillTimer(hWnd, timerID);
> +	   timerID = 0;
> +	   sharedTimerFiredFunction();
>      } else

Should we call stopSharedTimer here instead of duplicating its code?

It might be worth calling out that the bug fix here was the addition of the !
operator, since the other changes in the patch kind of obscure that fact.

r=me