[webkit-reviews] review requested: [Bug 23932] Current API does not allow us to open target="_blank" links in new tabs instead of windows : [Attachment 28850] New version of the patch

[bugzilla-daemon at webkit.org]

Alejandro Garcia Castro <alex at igalia.com> has asked  for review:
Bug 23932: Current API does not allow us to open target="_blank" links in new
tabs instead of windows
https://bugs.webkit.org/show_bug.cgi?id=23932

Attachment 28850: New version of the patch
https://bugs.webkit.org/attachment.cgi?id=28850&action=review

------- Additional Comments from Alejandro Garcia Castro <alex at igalia.com>
New version of the patch, I've reviewed the behavior when the handler returns
TRUE after talking to Xan. We have also added more information about the
signals to the documentation trying to clarify how to use this signal:

     * Emitted when @frame requests opening a new window. With this
     * signal the browser can use the context of the request to decide
     * about the new window. If the request is not handled the default
     * behavior is to allow opening the new window to load the url,
     * which will cause a create-web-view signal emission where the
     * browser hanbles the new window action but without information
     * of the context that caused the navigation. The following
     * navigation-policy-decision-requested emissions will load the
     * page after the creation of the new window just with the
     * information of this new navigation context, without any
     * information about the action that made this new window to be
     * opened.