[webkit-reviews] review requested: [Bug 24739] Combine StringImpl struct and data allocations : [Attachment 28828] updated patch to address comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 21 19:42:14 PDT 2009


Mike Belshe <mike at belshe.com> has asked Darin Adler <darin at apple.com> for
review:
Bug 24739: Combine StringImpl struct and data allocations
https://bugs.webkit.org/show_bug.cgi?id=24739

Attachment 28828: updated patch to address comments.
https://bugs.webkit.org/attachment.cgi?id=28828&action=review

------- Additional Comments from Mike Belshe <mike at belshe.com>
Addressed the naming issues.
Did not remove the boolean because of previous comment; the fact that the
address of the buffer starts immediately after the StringImpl is not a
guarantee that it was allocated in one chunk.
Took a different approach to solving the valgrind mis-matched free problem. 
Since we really want this class to control how the StringImpl is allocated,
overriding new & delete works well.


More information about the webkit-reviews mailing list