[webkit-reviews] review denied: [Bug 24720] <input type="range"> invisible in Chromium port : [Attachment 28790] patch v1

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Peter Kasting
<pkasting at google.com>'s request for review:
Bug 24720: <input type="range"> invisible in Chromium port
https://bugs.webkit.org/show_bug.cgi?id=24720

Attachment 28790: patch v1
https://bugs.webkit.org/attachment.cgi?id=28790&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: WebCore/rendering/RenderThemeChromiumWin.cpp

>+bool RenderThemeChromiumWin::paintSliderTrack(RenderObject* o, const
RenderObject::PaintInfo& i, const IntRect& r)
>+{
>+    const ThemeData& themeData = getThemeData(o);
>+
>+    WebCore::ThemePainter painter(i.context, r);
>+    ChromiumBridge::paintTrackbar(painter.context(),

Looks like you forgot to include your changes to ChromiumBridge in this patch.


>     case ListboxPart:
>     case MenulistPart:
>     case SearchFieldPart:
>     case TextFieldPart:
>     case TextAreaPart:
>-	  result.m_part = ETS_NORMAL;
>+	  result.m_part = EP_EDITTEXT;

what is the reason for this change?