[webkit-reviews] review denied: [Bug 24692] Allow ChromeClientChromium to access an HTML select element's menu items : [Attachment 28757] Updated patch to allow platform specific handling of Chromium HTML select popups

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 24692: Allow ChromeClientChromium to access an HTML select element's menu
items
https://bugs.webkit.org/show_bug.cgi?id=24692

Attachment 28757: Updated patch to allow platform specific handling of Chromium
HTML select popups
https://bugs.webkit.org/attachment.cgi?id=28757&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
Windows and Linux implementations are exactly the same, and it is bad to
duplicate code.  How about using #ifdefs in PopupMenuChromium.cpp to select
between Mac and non-Mac?

also, it seems like it would be nicer to have a single struct that contains the
entire 'model' for the PopupMenu.  that would include itemHeight, selectedIndex
and menuItems.