[webkit-reviews] review granted: [Bug 24706] Need to remove encoding() from ScriptExecutionContext : [Attachment 28803] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 20 15:09:42 PDT 2009
Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 24706: Need to remove encoding() from ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=24706
Attachment 28803: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=28803&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> + m_cachedScript = document->docLoader()->requestScript(m_scriptURL,
UTF8Encoding().name());
The name is "UTF-8", there is no need to get it in such a roundabout way.
> + m_decoder = TextResourceDecoder::create("text/javascript",
UTF8Encoding().name());
Ditto.
r=me
More information about the webkit-reviews
mailing list