[webkit-reviews] review granted: [Bug 24586] maxDeepOffset is confusing and should be removed : [Attachment 28788] Squashed patch with renames

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 24586: maxDeepOffset is confusing and should be removed
https://bugs.webkit.org/show_bug.cgi?id=24586

Attachment 28788: Squashed patch with renames
https://bugs.webkit.org/attachment.cgi?id=28788&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Justin reviewed this over IRC (from the shuttle).  

His comments:

some weird formatting in the change log

FIXED.

in the second line of the section that starts with "editing positions"
don't really need "deep"

I'm going to leave it for now.	The point was to identify that it was inside
the node if possible.  We can change it later (since this code is still very in
flux.)

the rest of the editing code will treat [img, 0]
+// as "the first position before the image"
just "the position before the image" i think

Will fix.

Thanks again Justin!