[webkit-reviews] review requested: [Bug 24122] REGRESSION: DOM Range extractContents/deleteContents bug : [Attachment 28771] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 24122: REGRESSION: DOM Range extractContents/deleteContents bug
https://bugs.webkit.org/show_bug.cgi?id=24122

Attachment 28771: proposed fix
https://bugs.webkit.org/attachment.cgi?id=28771&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I couldn't find any remnants of code that could make this work, so it's
surprising that this is a regression. Perhaps this code was removed in hopes
that Document::textRemoved() would automatically take care of fixing the range?
It does not, and it is not supposed to - I've verified that a range that's
equal to the one that deleteContents is invoked on ends up being different from
it in Firefox:

var range1 = something
var range2 = the same
range1.deleteContents()
// Both ranges are fixed, but differently - range1 is always collapsed, but
range2 may not be.