[webkit-reviews] review denied: [Bug 24689] Upstream V8 bindings for Workers proxies. : [Attachment 28758] Updated patch.

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 24689: Upstream V8 bindings for Workers proxies.
https://bugs.webkit.org/show_bug.cgi?id=24689

Attachment 28758: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=28758&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
We're very, very close! One more round of bathing, as eseidel used to say, and
we're home.

> +    v8::HandleScope scope;
> +    v8::Persistent<v8::Object> wrapper =
GetDOMObjectMap().get(m_workerContext);
> +    if (!wrapper.IsEmpty())
> +	   V8Proxy::SetDOMWrapper(wrapper, V8ClassIndex::INVALID_CLASS_INDEX,
NULL);
> +    GetDOMObjectMap().forget(m_workerContext);

domObjectMap
> +
> +    // Insert the object instance as the prototype of the shadow object.
> +    v8::Handle<v8::Object> v8_global = m_context->Global();
> +    v8_global->Set(implicitProtoString, jsWorkerContext);
> +}

global or globalObject

> +    // Non DOM node
> +    v8::Persistent<v8::Object> result = GetDOMObjectMap().get(impl);

domObjectMap

> +    v8::Handle<v8::Object> wrapper = GetDOMObjectMap().get(event);

domObjectMap

> +    if (GetDOMObjectMap().contains(event)) {
> +	   GetDOMObjectMap().forget(event);

getDOMObjectMap