[webkit-reviews] review granted: [Bug 24686] Hit testing child RenderLayers of transformed layers is broken : [Attachment 28746] Patch, testcases, changelog

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 24686: Hit testing child RenderLayers of transformed layers is broken
https://bugs.webkit.org/show_bug.cgi?id=24686

Attachment 28746: Patch, testcases, changelog
https://bugs.webkit.org/attachment.cgi?id=28746&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>

> +	   if (hitTestContents(request, tempResult, layerBounds, hitTestPoint,
HitTestSelf) &&
> +		   isHitCandidate(this, false, zOffsetForContentsPtr,
unflattenedTransformState.get())) {

Seems like funny indentation to me here.  I usually just line up multiple lines
with && or || chains, e.g.,

if (hitTestContents(request, tempResult, layerBounds, hitTestPoint,
HitTestSelf) &&
    isHitCandidate(this, false, zOffsetForContentsPtr,
unflattenedTransformState.get())) {

r=me