[webkit-reviews] review requested: [Bug 24684] Clean up WebCore based on Coverty Prevent static analysis results : [Attachment 28756] First pass cleanup with changelog, all tests pass

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 19 11:42:33 PDT 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 24684: Clean up WebCore based on Coverty Prevent static analysis results
https://bugs.webkit.org/show_bug.cgi?id=24684

Attachment 28756: First pass cleanup with changelog, all tests pass
https://bugs.webkit.org/attachment.cgi?id=28756&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog				    |  107 +++++++++++++++++
 WebCore/css/CSSFontSelector.cpp		    |	12 ++-
 WebCore/css/CSSStyleSelector.cpp		    |	 6 +
 WebCore/css/CSSStyleSheet.cpp			    |	 7 +-
 WebCore/css/SVGCSSStyleSelector.cpp		    |  121 +++++---------------
 WebCore/dom/ContainerNode.cpp			    |	14 +-
 WebCore/dom/Document.cpp			    |	 2 -
 WebCore/editing/ApplyStyleCommand.cpp		    |	10 +-
 .../editing/InsertParagraphSeparatorCommand.cpp    |	 3 +-
 WebCore/editing/markup.cpp			    |	 3 +-
 WebCore/html/CanvasStyle.cpp			    |	13 ++-
 WebCore/loader/TextDocument.cpp		    |	13 ++-
 WebCore/page/FocusController.cpp		    |	 6 +-
 WebCore/page/animation/AnimationBase.h 	    |	 5 +-
 WebCore/page/animation/AnimationController.cpp     |	 1 +
 WebCore/page/animation/ImplicitAnimation.cpp	    |	 3 +-
 WebCore/page/animation/ImplicitAnimation.h	    |	 4 +-
 WebCore/page/animation/KeyframeAnimation.cpp	    |	 2 +-
 WebCore/page/animation/KeyframeAnimation.h	    |	 4 +-
 WebCore/platform/chromium/PasteboardChromium.cpp   |	19 ++--
 WebCore/platform/graphics/GlyphPageTreeNode.cpp    |	 1 +
 .../transforms/PerspectiveTransformOperation.cpp   |	 5 +-
 .../transforms/RotateTransformOperation.cpp	    |	 8 +-
 WebCore/rendering/RenderLayer.cpp		    |	12 +-
 WebCore/rendering/RenderTableSection.cpp	    |	 8 +-
 WebCore/rendering/SVGRenderSupport.cpp 	    |	 2 +-
 WebCore/rendering/bidi.cpp			    |	 3 +-
 27 files changed, 226 insertions(+), 168 deletions(-)


More information about the webkit-reviews mailing list