[webkit-reviews] review granted: [Bug 24654] REGRESSION (Safari 4): Incorrect function return value when using IE "try ... finally" memory leak work-around : [Attachment 28718] Fix codegen for return statements if there are finalisers present.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 23:39:36 PDT 2009


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 24654: REGRESSION (Safari 4): Incorrect function return value when using IE
"try ... finally" memory leak work-around
https://bugs.webkit.org/show_bug.cgi?id=24654

Attachment 28718: Fix codegen for return statements if there are finalisers
present.
https://bugs.webkit.org/attachment.cgi?id=28718&action=review

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
I like returnRegister more than returnReg, and it matches what we use elsewhere
in the JIT codegen. Other than that, r=me if perf is fine. I always like seeing
tests in the newer format.


More information about the webkit-reviews mailing list