[webkit-reviews] review requested: [Bug 24540] Fix for missing mmap features in Symbian : [Attachment 28716] Updated patch for bug 24540

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 19:17:54 PDT 2009


Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 24540: Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540

Attachment 28716: Updated patch for bug 24540
https://bugs.webkit.org/attachment.cgi?id=28716&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
I implemented the changes as suggested by Mark Rowe in his review.
In particular:
- The PLATFORM(SYMBIAN) conditional changes are now outside the
HAVE(MMAP)blocks
- I created a new ExecutableAllocatorSymbian.cpp instead of embedding the
symbian changes within ExecutableAllocatorPosix.cpp
- I removed the patch for TCSystemAlloc. According to the processing logic, it
is sufficient to utilize the sbrk feature (SBRK is already set true for Symbian
anyway).


More information about the webkit-reviews mailing list