[webkit-reviews] review requested: [Bug 24653] WebKit should be buildable without prefix header injection : [Attachment 28708] v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 16:17:47 PDT 2009


Mark Mentovai <mark at chromium.org> has asked Mark Rowe (bdash) <mrowe at apple.com>
for review:
Bug 24653: WebKit should be buildable without prefix header injection
https://bugs.webkit.org/show_bug.cgi?id=24653

Attachment 28708: v4
https://bugs.webkit.org/attachment.cgi?id=28708&action=review

------- Additional Comments from Mark Mentovai <mark at chromium.org>
OK, in addition to the removal of the NSPoint/NSRect forward declarations, this
version is more careful to use #import for the guard-less AppKit headers, and
fixes the order in one file I missed the sort on.

I think this should be the final version.  It works with both the Chromium
build (with prefix header injection disabled) and the stock WebKit Mac build
(with the precompiled prefix header).


More information about the webkit-reviews mailing list