[webkit-reviews] review granted: [Bug 24653] WebKit should be buildable without prefix header injection : [Attachment 28701] Sorted as requested
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 17 15:25:47 PDT 2009
Mark Rowe (bdash) <mrowe at apple.com> has granted Mark Mentovai
<mark at chromium.org>'s request for review:
Bug 24653: WebKit should be buildable without prefix header injection
https://bugs.webkit.org/show_bug.cgi?id=24653
Attachment 28701: Sorted as requested
https://bugs.webkit.org/attachment.cgi?id=28701&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +typedef unsigned int NSFontTraitMask;
In 10.5 and beyond NSFontTraitMask is declared by AppKit as a NSUInteger. I
suspect that this will lead to problems, possibly a build breakage, in 64-bit
where NSUInteger is a typedef of unsigned long rather than unsigned int.
r=me if you've verified that this doesn't break the 64-bit build.
More information about the webkit-reviews
mailing list