[webkit-reviews] review denied: [Bug 24653] WebKit should be buildable without prefix header injection : [Attachment 28698] Adds missing #includes and forward declarations as needed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 17 14:40:50 PDT 2009
Mark Rowe (bdash) <mrowe at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 24653: WebKit should be buildable without prefix header injection
https://bugs.webkit.org/show_bug.cgi?id=24653
Attachment 28698: Adds missing #includes and forward declarations as needed
https://bugs.webkit.org/attachment.cgi?id=28698&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The includes need to be consistently sorted in case-sensitive alphabetical
order. In some places this was done, but in others they were not sorted or
were added in a separate paragraph from existing includes. #import or #include
should be used consistently within FoundationExtras.h, and the includes should
not be added in between the comment describing HardRetain/HardRelease and their
definitions.
More information about the webkit-reviews
mailing list