[webkit-reviews] review requested: [Bug 24600] [GTK] responses with status code >= 400 should not be given special treatment : [Attachment 28695] proposed fix

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 24600: [GTK] responses with status code >= 400 should not be given special
treatment
https://bugs.webkit.org/show_bug.cgi?id=24600

Attachment 28695: proposed fix
https://bugs.webkit.org/attachment.cgi?id=28695&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
This patch differs from the other in that it also does not give special
treatment to 304 regarding gotHeaders and gotChunk, but does avoid trying a
content sniff on it. On my local setup, I get the following impact on the http
tests:

Without the patch:

Fails:

http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html
http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html
http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html
http/tests/xmlhttprequest/web-apps/013.html

Crashes:

http/tests/xmlhttprequest/web-apps/002-simple.html

With the patch:

Fails:

http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html
http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html