[webkit-reviews] review requested: [Bug 24645] bisect-builds script doesn't work with Safari 4 Public Beta (version string) : [Attachment 28693] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 11:19:38 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version
string)
https://bugs.webkit.org/show_bug.cgi?id=24645

Attachment 28693: Patch v1
https://bugs.webkit.org/attachment.cgi?id=28693&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This fixes bisect-builds with Safari 4 Public Beta.

The long-term fix is to switch from using "CFBundleShortVersionString" to using
"CFBundleVersion" in findSafariVersion().


More information about the webkit-reviews mailing list