[webkit-reviews] review granted: [Bug 24493] [GTK] Misc patches for WebKitWebHistoryItem : [Attachment 28473] add WebKitWebHistoryItem unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 10:39:04 PDT 2009

Holger Freyther <zecke at selfish.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 24493: [GTK] Misc patches for WebKitWebHistoryItem

Attachment 28473: add WebKitWebHistoryItem unit test

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>  # Build unit test
> -noinst_PROGRAMS += Programs/UnitTests
> +noinst_PROGRAMS += Programs/UnitTests Programs/WebHistoryItemUnitTests

okay, this needs rediffing as of bug #24039.

> +static void
> +test_webkit_web_history_item_alternate_title(WebHistoryItemFixture* fixture,

> +						gconstpointer data)

inconsistency with the new lines...

More information about the webkit-reviews mailing list