[webkit-reviews] review granted: [Bug 24592] [GTK] Crash in FcPatternHash : [Attachment 28690] pangofonts.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 24592: [GTK] Crash in FcPatternHash
https://bugs.webkit.org/show_bug.cgi?id=24592

Attachment 28690: pangofonts.patch
https://bugs.webkit.org/attachment.cgi?id=28690&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> -  PangoFontMap* FontPlatformData::m_fontMap = 0;
> -  GHashTable* FontPlatformData::m_hashTable = 0;
> +PangoFontMap* FontPlatformData::m_fontMap = 0;
> +GHashTable* FontPlatformData::m_hashTable = 0;

maybe move this to the style patch?


>  
>  FontPlatformData::FontPlatformData(const FontDescription& fontDescription,
const AtomicString& familyName)
>      : m_context(0)
> @@ -193,7 +194,20 @@ bool FontPlatformData::init()
>  
>  FontPlatformData::~FontPlatformData()
>  {
> -    // Destroy takes place in FontData::platformDestroy().
> +    if (m_font && m_font != reinterpret_cast<PangoFont*>(-1)) {

probably the same as with the previous patch. (-1)