[webkit-reviews] review granted: [Bug 24638] [GTK] HTML5 media tags do not work : [Attachment 28679] fix repainting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 16 22:43:51 PDT 2009

Mark Rowe (bdash) <mrowe at apple.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 24638: [GTK] HTML5 media tags do not work

Attachment 28679: fix repainting

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +void mediaPlayerPrivateRepaintCallback(WebKitVideoSink* sink, gpointer data)

> +{
> +    MediaPlayerPrivate* playerPrivate =
> +    playerPrivate->repaint();
> +}

The function should be declared static, and the name of the first argument
omitted since it is unused.  You could probably do away with the local variable
too without losing any clarity.


More information about the webkit-reviews mailing list