[webkit-reviews] review requested: [Bug 24623] Refactor ConsoleMessage to use ScriptFunctionCall : [Attachment 28662] Use ScriptFuncitonCall with ConsoleMessage, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 16 16:09:01 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 24623: Refactor ConsoleMessage to use ScriptFunctionCall
https://bugs.webkit.org/show_bug.cgi?id=24623

Attachment 28662: Use ScriptFuncitonCall with ConsoleMessage, v1
https://bugs.webkit.org/attachment.cgi?id=28662&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 WebCore/ChangeLog				|   28 ++++++
 WebCore/bindings/js/ScriptFunctionCall.cpp	|   12 +++
 WebCore/bindings/js/ScriptFunctionCall.h	|    3 +
 WebCore/bindings/js/ScriptObjectQuarantine.cpp |    7 ++
 WebCore/bindings/js/ScriptObjectQuarantine.h	|    5 +
 WebCore/bindings/js/ScriptValue.cpp		|   11 ++
 WebCore/bindings/js/ScriptValue.h		|    1 +
 WebCore/inspector/ConsoleMessage.cpp		|  119 ++++++++++++++----------
 WebCore/inspector/ConsoleMessage.h		|   29 +++---
 WebCore/inspector/InspectorController.cpp	|   59 +-----------
 WebCore/inspector/InspectorController.h	|    1 -
 11 files changed, 154 insertions(+), 121 deletions(-)


More information about the webkit-reviews mailing list