[webkit-reviews] review denied: [Bug 24456] Chromium Unforking: Split ColorChromium.cpp into Windows + Mac variants : [Attachment 28477] patch1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 15 08:40:26 PDT 2009
Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 24456: Chromium Unforking: Split ColorChromium.cpp into Windows + Mac
variants
https://bugs.webkit.org/show_bug.cgi?id=24456
Attachment 28477: patch1
https://bugs.webkit.org/attachment.cgi?id=28477&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>+++ b/WebCore/ChangeLog
>+2009-03-11 Jeremy Moskovich <jeremy at chromium.org>
>+
>+ Reviewed by NOBODY (OOPS!).
>+
>+ Split ColorChromium.cpp into Mac & Windows variants.
>+ Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since
we
>+ ultimately need to take a different approach. For now,
createCGColor()
>+ is copied from ColorMac.mm.
>+
>+ No observable change in behavior, so no test.
nit: please add a bug link in here.
>+
>+ * platform/graphics/chromium/ColorChromium.cpp:
>+ (WebCore::focusRingColor):
>+ * platform/graphics/chromium/ColorChromiumMac.mm: Added.
>+ (WebCore::focusRingColor):
>+ (WebCore::nsColor):
>+ (WebCore::CGColorFromNSColor):
>+ (WebCore::createCGColor):
nit: for newly added files, please remove the lines that mention the newly
added
functions. i wish prepare-ChangeLog did that automatically :-/
>+++ b/WebCore/platform/graphics/chromium/ColorChromiumMac.mm
>@@ -0,0 +1,131 @@
>+/*
>+ * Copyright (C) 2008 Google Inc. All rights reserved.
This copyright info is not correct, right?
More information about the webkit-reviews
mailing list