[webkit-reviews] review requested: [Bug 24586] maxDeepOffset is confusing and should be removed : [Attachment 28605] Further efforts to remove maxDeepOffset

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 13 15:23:24 PDT 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 24586: maxDeepOffset is confusing and should be removed
https://bugs.webkit.org/show_bug.cgi?id=24586

Attachment 28605: Further efforts to remove maxDeepOffset
https://bugs.webkit.org/attachment.cgi?id=28605&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog			    |	57 ++++++++++++++++++++++++++++
 WebCore/dom/Position.cpp		    |	44 +++++++++++++--------
 WebCore/dom/Position.h 		    |	 7 ++-
 WebCore/dom/PositionIterator.cpp	    |	18 ++++++---
 WebCore/editing/DeleteSelectionCommand.cpp |	 9 ++--
 WebCore/editing/Editor.cpp		    |	 4 +-
 WebCore/editing/VisiblePosition.cpp	    |	12 +++--
 WebCore/editing/htmlediting.cpp	    |	18 +++++----
 WebCore/editing/htmlediting.h		    |	 2 +-
 WebCore/editing/visible_units.cpp	    |	21 +++++-----
 10 files changed, 135 insertions(+), 57 deletions(-)


More information about the webkit-reviews mailing list