[webkit-reviews] review requested: [Bug 20797] add Settings entries for per-script/lang generic family : [Attachment 28601] patch that should build for ports not using ICU

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 13 14:32:15 PDT 2009


Jungshik Shin <jshin at chromium.org> has asked Darin Fisher (:fishd, Google)
<darin at chromium.org> for review:
Bug 20797: add Settings entries for per-script/lang generic family
https://bugs.webkit.org/show_bug.cgi?id=20797

Attachment 28601: patch that should build for ports not using ICU
https://bugs.webkit.org/attachment.cgi?id=28601&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
I copied ICU's UScriptCode enum (from icu/unicode/uscript.h) to
platform/text/UScriptCode.h (expecting it to be used in files other than
Settings.{h,cpp} being changed in the current patch). So, this patch can be
used on ports that do not use ICU as well. 

I'm not sure what to do about the copyright statement/license at the beginning.
I put ICU's copyright and license statements at the beginning of UScriptCode.h
because it's almost a verbatim copy of the first part of uscript.h.


More information about the webkit-reviews mailing list