[webkit-reviews] review requested: [Bug 24586] maxDeepOffset is confusing and should be removed : [Attachment 28593] First attempt to kill maxDeepOffset

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 24586: maxDeepOffset is confusing and should be removed
https://bugs.webkit.org/show_bug.cgi?id=24586

Attachment 28593: First attempt to kill maxDeepOffset
https://bugs.webkit.org/attachment.cgi?id=28593&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog			     |	 50 +++++++++++++++++++++++++++
 WebCore/dom/Position.cpp		     |	 20 ++++++++--
 WebCore/dom/Position.h 		     |	  5 +++
 WebCore/editing/CompositeEditCommand.cpp    |	  4 +-
 WebCore/editing/DeleteSelectionCommand.cpp  |	  8 ++---
 WebCore/editing/Editor.cpp		     |	  1 +
 WebCore/editing/InsertLineBreakCommand.cpp  |	  3 +-
 WebCore/editing/InsertListCommand.cpp	     |	  4 +-
 WebCore/editing/ReplaceSelectionCommand.cpp |	  5 ++-
 WebCore/editing/TypingCommand.cpp	     |	  2 +-
 WebCore/editing/VisibleSelection.cpp	     |	  6 ++--
 WebCore/editing/htmlediting.cpp	     |	 26 +++++++------
 WebCore/editing/visible_units.cpp	     |	  6 ++--
 WebCore/page/AccessibilityObject.cpp	     |	  4 +-
 WebCore/page/AccessibilityRenderObject.cpp  |	 13 ++++---
 WebCore/rendering/RenderBox.cpp	     |	  9 ++---
 16 files changed, 118 insertions(+), 48 deletions(-)