[webkit-reviews] review denied: [Bug 24536] Cannot resolve include file : [Attachment 28582] Cleaned-up patch for 24536
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 13 11:41:02 PDT 2009
Mark Rowe (bdash) <mrowe at apple.com> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 24536: Cannot resolve include file
https://bugs.webkit.org/show_bug.cgi?id=24536
Attachment 28582: Cleaned-up patch for 24536
https://bugs.webkit.org/attachment.cgi?id=28582&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
In a .cpp file named Foo our policy is to include config.h first, followed by
Foo.h, followed by any remaining headers that the file needs. It seems to me
that if your compiler is choking on this code for some reason, it is buggy and
should be fixed.
More information about the webkit-reviews
mailing list