[webkit-reviews] review requested: [Bug 24536] Cannot resolve include file : [Attachment 28582] Cleaned-up patch for 24536

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 13 10:25:54 PDT 2009


Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 24536: Cannot resolve include file
https://bugs.webkit.org/show_bug.cgi?id=24536

Attachment 28582: Cleaned-up patch for 24536
https://bugs.webkit.org/attachment.cgi?id=28582&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
According to review comments:

- I removed the change for RefPtr.h (we will resolve this with a compiler fix
rather than webkit code change).

- I removed the second include Profile.h. This was omitted in the initial
patch. The intention was to change the order of header includes, and not to add
a second Profile.h. Without this changed order, our compiler cannot resolve
WTF::PassRefPtr<JSC::Profile>, as referenced in ProfileGenerator.h.


More information about the webkit-reviews mailing list