[webkit-reviews] review granted: [Bug 24262] [Qt] SVGs stroked text support missing : [Attachment 28119] stroked texts on Qt

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 24262: [Qt] SVGs stroked text support missing
https://bugs.webkit.org/show_bug.cgi?id=24262

Attachment 28119: stroked texts on Qt
https://bugs.webkit.org/attachment.cgi?id=28119&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> -    p->drawText(pt, string, flags, run.padding());
> +
> +    if (ctx->textDrawingMode() & cTextStroke) {
> +	   QPainterPath path;
> +	   path.addText(pt, font(), string);
> +	   p->strokePath(path, p->pen());
> +    }
> +    if (ctx->textDrawingMode() & cTextFill)
> +	   p->drawText(pt, string, flags, run.padding());

cool, can you point me to a test case that is having cTextStroke and cTextFill
for drawing text?