[webkit-reviews] review granted: [Bug 24562] Add custom V8 binding for Document.getCSSCanvasContext : [Attachment 28557] patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Mike Belshe
<mike at belshe.com>'s request for review:
Bug 24562: Add custom V8 binding for Document.getCSSCanvasContext
https://bugs.webkit.org/show_bug.cgi?id=24562

Attachment 28557: patch
https://bugs.webkit.org/attachment.cgi?id=28557&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looks good, aside for helper functions.

Also, don't forget to put bug URL in the ChangeLog. I usually do:

URL
Description.

(standard stuff prepareChangelog puts in)

> +    String contextId = ToWebCoreString(args[0]);

toWebCoreString

> +    String name = ToWebCoreString(args[1]);

Ditto.

> +    int width = ToInt32(args[2]);

toInt32
> +    int height = ToInt32(args[3]);
Ditto.
> +    CanvasRenderingContext2D* result = imp->getCSSCanvasContext(contextId,
name, width, height);
> +    return V8Proxy::ToV8Object(V8ClassIndex::CANVASRENDERINGCONTEXT2D,
result);
> +}
> +
>  } // namespace WebCore