[webkit-reviews] review requested: [Bug 24496] ChromeClients don't get addMessageToConsole() called for non-string arguments : [Attachment 28551] 2009-03-12 Dimitri Glazkov <dglazkov at chromium.org>
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 12 13:57:36 PDT 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked for review:
Bug 24496: ChromeClients don't get addMessageToConsole() called for non-string
arguments
https://bugs.webkit.org/show_bug.cgi?id=24496
Attachment 28551: 2009-03-12 Dimitri Glazkov <dglazkov at chromium.org>
https://bugs.webkit.org/attachment.cgi?id=28551&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=24525
REGRESSION: Inspector window doesn't close when inspected page is
destroyed. This is a revert of r41158, which became unnecessary when
InspectorController became ref-counted in r41462.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::inspectedPageDestroyed): Reset
m_inspectedPage
after calling close().
(WebCore::InspectorController::stopUserInitiatedProfiling): Remove
m_inspectedPage check guard around profile logic.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41643
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
WebCore/ChangeLog | 15 +++++++++++++++
WebCore/inspector/InspectorController.cpp | 14 ++++++--------
2 files changed, 21 insertions(+), 8 deletions(-)
More information about the webkit-reviews
mailing list